-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server)!: oauth encryption algorithm setting #6818
Conversation
Deploying with Cloudflare Pages
|
f0d17b7
to
8bb21c5
Compare
8bb21c5
to
2045473
Compare
Well this was a fun redirect loop. For anyone else surprised by this and disabled local login
I'm still trying to figure out how to configure authentik with cert-manager to use rs instead |
i'm a noob in outh, how to do "(1) update the signing algorithm in Immich " as mentioned in release note?? |
Log in as the immich admin and click on "Administration" then "Settings" then "OAuth" |
Notes from @jrasm91:
Warning
Breaking Change
OAuth setups using
HS256
(mainly Authentik) will need to either (1) update the signing algorithm in Immich or (2) specify a signing key in the provider settings (so that it usesRS256
instead).Specify a signing key in Authentik:
Screencast.from.02-02-2024.12.05.04.AM.webm
New Immich OAuth Setting
Background
RS256
is generally better thanHS256
.RS256
is pretty much the most commonly used algorithm. The client library we use for open-id defaults toRS256
. It's very easy to setup Authentik without specifying a signing key, which will default to useHS256
. The original implementation added a hack/fallback toHS256
in some conditions to try to handle that situation. The current code removes the fallback, and adds a specificSigning Algortithm
setting which can be explicitly set. Alternatively, the issue could be fixed by specifying a signing key in Authentik.References: