Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): improved album view UI & album card UI #6822

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

azroberts8
Copy link
Contributor

@azroberts8 azroberts8 commented Jan 31, 2024

This PR horizontally expands the asset grid when viewing an album to reduce the large margins on the left and right side of the page. This makes better utilization of screen real estate allowing users to preview more photos at once without reducing thumbnail size like in Google Photos. This PR also modifies the album cards to have a cleaner hover effect.

Before After
image image
image image

@jrasm91
Copy link
Contributor

jrasm91 commented Feb 1, 2024

Can you add before and after screenshots to the pull request description please?

@azroberts8
Copy link
Contributor Author

Sure! Just added screenshots

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks nice, thanks!

@alextran1502 alextran1502 merged commit e4d0560 into immich-app:main Feb 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants