Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ml): openvino not working with dynamic axes #6871

Merged
merged 10 commits into from
Feb 3, 2024

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Feb 3, 2024

Description

There's an upstream bug with OpenVINO where it can't handle ONNX models with dynamic axes. This can cause errors for CLIP models as they all have dynamic axes. Facial recognition models are fixed at a batch size of 1, so they don't have this issue.

Fixes #6869

Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a12860e
Status: ✅  Deploy successful!
Preview URL: https://65eb7745.immich.pages.dev
Branch Preview URL: https://fix-ml-openvino-dynamic-axes.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mertalev mertalev marked this pull request as draft February 3, 2024 01:27
@mertalev mertalev marked this pull request as ready for review February 3, 2024 05:32
@mertalev mertalev enabled auto-merge (squash) February 3, 2024 05:32
@mertalev mertalev merged commit 79d3342 into main Feb 3, 2024
24 checks passed
@mertalev mertalev deleted the fix/ml-openvino-dynamic-axes branch February 3, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants