Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): use upload api and update documentation #6927

Merged
merged 5 commits into from
Feb 6, 2024
Merged

chore(cli): use upload api and update documentation #6927

merged 5 commits into from
Feb 6, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Feb 5, 2024

  • Don't manually call fetch for the upload file
  • Streamline the upload code
  • Fix the include hidden option
  • Improve documentation
  • Bump to version 2.0.7

@etnoy etnoy added the cli Tasks related to the Immich CLI label Feb 5, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb3dc90
Status: ✅  Deploy successful!
Preview URL: https://e9c96adb.immich.pages.dev
Branch Preview URL: https://chore-cli-upload-fetch.immich.pages.dev

View logs

jrasm91
jrasm91 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you test uploading a sidecar file?

cli/src/commands/upload.command.ts Outdated Show resolved Hide resolved
@etnoy etnoy merged commit 755444e into main Feb 6, 2024
24 checks passed
@etnoy etnoy deleted the chore/cli-upload-fetch branch February 6, 2024 10:00
@benmccann
Copy link
Contributor

Cool. Thanks! This was something I noticed and was on my list too 😆 Something that would be good to confirm if you didn't already is that the axios and fetch clients use the same date serialization

@etnoy
Copy link
Contributor Author

etnoy commented Feb 7, 2024

Cool. Thanks! This was something I noticed and was on my list too 😆 Something that would be good to confirm if you didn't already is that the axios and fetch clients use the same date serialization

You don't want to know how long I fought with the axios sdk to get uploads working. In the end I had to concede to do manual http calls instead.

With fetch, it just worked. Thanks for helping me with it

@benmccann benmccann mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etnoy @benmccann @jrasm91