-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): replace axios dependency by fetch #7018
Conversation
Deploying with Cloudflare Pages
|
async getGitHubRelease(): Promise<GitHubRelease> { | ||
const response = await fetch('https://api.github.com/repos/immich-app/immich/releases/latest'); | ||
if (!response.ok) { | ||
throw new Error('Failed to fetch GitHub release'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you log or throw the actual details of the failure? otherwise it's extremely frustrating to troubleshoot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Amazing! Thank you! I had an issue for this in #6647 and managed to remove |
Ahah, I tried to migrate from axios to typescript-fetch 1-2 weeks ago right before your changes, I will resume this work next week. Help is always welcome 😄 |
Cool. I just added some details of where I left off here: #6647 (comment). I was using |
Replace axios dependency by fetch