feat(mobile): thumbhash support #7028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
147b748
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70b233f7.immich.pages.dev |
| Branch Preview URL: | https://feat-mobile-thumbhash.immich.pages.dev |
fyfrey
reviewed
Feb 11, 2024
mobile/lib/shared/models/asset.dart
Outdated
| @@ -116,6 +118,8 @@ class Asset { | |||
| /// because Isar cannot sort lists of byte arrays | |||
| String checksum; | |||
|
|
|||
| String? thumbhash; | |||
There was a problem hiding this comment.
Please make this a List<byte> to store the raw bytes instead of the longer base64. This also avoids the wasteful decoding of base64 to bytes on every render.
There was a problem hiding this comment.
Updated. Thank you 😄
fyfrey
reviewed
Feb 11, 2024
shenlong-tanwen
force-pushed
the
feat/mobile-thumbhash
branch
from
20eb35a to
147b748
Compare
fyfrey
reviewed
Feb 12, 2024
| if (hash == null) { | ||
| return null; | ||
| } | ||
| return base64.decode(base64.normalize(hash)).toList(); |
There was a problem hiding this comment.
base64.decode already returns an Uint8List. No need to call toList() which makes it less efficient.
also, I don't think normalize is needed?
There was a problem hiding this comment.
I'll merge this in to my branch and address this and the other comment there.
fyfrey
reviewed
Feb 12, 2024
| void initState() { | ||
| super.initState(); | ||
| if (widget.asset?.thumbhash != null) { | ||
| final bytes = Uint8List.fromList(widget.asset!.thumbhash!); |
There was a problem hiding this comment.
it should be safe to cast the thumbhash to an Uint8List (after my other comment is addressed). Isar also returns its List<byte> as Uint8List. This removes 1 unnecessary array copy operation.
alextran1502
added a commit
that referenced
this pull request
Feb 13, 2024
* Adds image provider * uses image provider * wip load preview * wip everything but activity asset thumbnail needs some help with a remote id * Immich provider used in gallery * First draft of the immich image provider, working nicely! * Removed OriginalImageProvider * Fixes for thumbnails * feat(mobile): thumbhash support (#7028) * feat(mobile): thumbhash support * perf(mobile): store bmp thumbhash bytes in Isar --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> * Uses octoimage for fade in and placeholders * fixes thumbnails, removes unused values, adds better thumbnail size * removes thumbhash support for now * Forgot one thumbhash removal * Use big thumbnail for local image on ios * fix(mobile): Multipart image loading for iOS double swipe (#7064) * uses local thumb first * Multipart thumbnail * Clean up file delete * await file delete * Fynn's comments, made thumbnail smaller and doesn't crash on erroring out on thumbnail * lint --------- Co-authored-by: Marty Fuhry <marty@fuhry.farm> Co-authored-by: Alex <alex.tran1502@gmail.com> * Moves http client to global private place for reuse * Got rid of usePreview for local image providers since we always show a thumbnail anyway first * linter --------- Co-authored-by: shenlong <139912620+shenlong-tanwen@users.noreply.github.com> Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> Co-authored-by: Alex <alex.tran1502@gmail.com> Co-authored-by: Marty Fuhry <marty@fuhry.farm>
shenlong-tanwen
added a commit
that referenced
this pull request
Feb 16, 2024
* feat(mobile): thumbhash support * perf(mobile): store bmp thumbhash bytes in Isar --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
shenlong-tanwen
added a commit
that referenced
this pull request
Feb 21, 2024
* feat(mobile): thumbhash support * perf(mobile): store bmp thumbhash bytes in Isar --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made: