fix(server): recognize faces when min. faces is set to 1 #7144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right that this check undermines a min face count of 1 in the sense that it behaves the same as a min face count of 2. But the optimization here effectively becomes reverted if the check is set to 0. It'd be better to have this condition check for whether the min face count is 1 and only allow a match length of 1 if so. |
mertalev
reviewed
Feb 16, 2024
mertalev
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6961 there was an optimization to face recognition, but it overlooks the scenario where
machineLearning.facialRecognition.minFacesis set to1, resulting in no person being created.Has been tested in an empty instance by setting MIN RECOGNIZED FACES to 1 and then uploading an image with a single face and match