refactor(web): websocket events #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Websocket functionality by implementing a new event bus for real-time communication. The current implementation relies on stores for this purpose, but I don't think they're the right tool for the job. While stores are suitable for scenarios where a value needs to persist in memory and be updated, they are not the best choice for real-time events.
The
on_upload_successevent has been re-enabled to show uploaded assets without refreshing the page. Previously, this event was commented out but the reason for that isn't clear. Additionally, several small bugs are fixed related to using stores, including issues with unsubscribing and multiple updates not working as expected.