fix(web): validation when editing asset date & time #7160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7831444
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d689fff0.immich.pages.dev |
| Branch Preview URL: | https://fix-web-edit-asset-date-vali.immich.pages.dev |
jrasm91
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing the date & time of an asset, the
Confirmbutton becomes disabled when clicked and the entered date is invalid. However, the button never gets re-enabled so you have to cancel and try again.Fixed by validating upon user input rather than on submit. Also removed a custom type definition for
Intl.supportedValuesOfby using SvelteKit's default tsconfig.json settings, replacing our"lib": ["es2020", "DOM"].