Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): improve feedback for favorite and archive actions #7232

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

michelheusschen
Copy link
Contributor

When you change the favorite or archival status of an asset using the selection bar, changes aren't visible immediately (except when the asset gets removed from the view). Now the favorite and archive icons inside an asset are updated whenever they are changed.

Also some bug fixes for the /albums/[id] page:

  • Archive icon inside assets never shows
  • Selected assets that are archived cannot be unarchived
  • Archive button shows when shared user doesn't own the asset

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 merged commit b896d45 into main Feb 20, 2024
25 of 26 checks passed
@alextran1502 alextran1502 deleted the feat/web-favorite-archive-action-feedback branch February 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants