-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add ctrl+a / ctrl+d shortcuts to select / deselect all assets #8105
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e39bbed
feat(web): use ctrl+a / ctrl+d to select / deselect all assets
Ethan13310 06580f3
fix(web): use shortcutList for ctrl+a / ctrl+d
Ethan13310 46f8d4e
fix(web): remove useless get()
Ethan13310 78fe526
feat(web): asset interaction store can now select many assets at once
Ethan13310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 10 additions & 28 deletions
38
web/src/lib/components/photos-page/actions/select-all-assets.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,24 @@ | ||
<script lang="ts"> | ||
import CircleIconButton from '$lib/components/elements/buttons/circle-icon-button.svelte'; | ||
import type { AssetInteractionStore } from '$lib/stores/asset-interaction.store'; | ||
import { BucketPosition, type AssetStore, isSelectAllCancelled } from '$lib/stores/assets.store'; | ||
import { handleError } from '$lib/utils/handle-error'; | ||
import { get } from 'svelte/store'; | ||
import { mdiTimerSand, mdiSelectAll } from '@mdi/js'; | ||
import { type AssetStore, isSelectingAllAssets } from '$lib/stores/assets.store'; | ||
import { mdiSelectAll, mdiTimerSand } from '@mdi/js'; | ||
import { selectAllAssets } from '$lib/utils/asset-utils'; | ||
|
||
export let assetStore: AssetStore; | ||
export let assetInteractionStore: AssetInteractionStore; | ||
|
||
let selecting = false; | ||
|
||
const handleSelectAll = async () => { | ||
try { | ||
$isSelectAllCancelled = false; | ||
selecting = true; | ||
|
||
const assetGridState = get(assetStore); | ||
for (const bucket of assetGridState.buckets) { | ||
if ($isSelectAllCancelled) { | ||
break; | ||
} | ||
await assetStore.loadBucket(bucket.bucketDate, BucketPosition.Unknown); | ||
for (const asset of bucket.assets) { | ||
assetInteractionStore.selectAsset(asset); | ||
} | ||
} | ||
await selectAllAssets(assetStore, assetInteractionStore); | ||
}; | ||
|
||
selecting = false; | ||
} catch (error) { | ||
handleError(error, 'Error selecting all assets'); | ||
} | ||
const handleCancel = () => { | ||
$isSelectingAllAssets = false; | ||
}; | ||
</script> | ||
|
||
{#if selecting} | ||
<CircleIconButton title="Delete" icon={mdiTimerSand} /> | ||
{/if} | ||
{#if !selecting} | ||
{#if $isSelectingAllAssets} | ||
<CircleIconButton title="Cancel" icon={mdiTimerSand} on:click={handleCancel} /> | ||
{:else} | ||
<CircleIconButton title="Select all" icon={mdiSelectAll} on:click={handleSelectAll} /> | ||
{/if} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we reverting back to the previous implementation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked that already and it handles edge cases better: #8105 (comment)