Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership annotations may panic with 'new and reprinted ASTs don't match' #148

Closed
TheDan64 opened this issue Aug 26, 2019 · 4 comments
Closed
Assignees
Labels
blocked Cannot be supported without external support first bug Something isn't working refactorer This issue relates to the refactoring tool

Comments

@TheDan64
Copy link
Contributor

fn test(#[nonnull] z: *mut u8) {
    *z = 1u8;
}
refactor:run_command("select", {"target", "crate; desc(fn || field);"})
refactor:run_command("ownership_annotate", {"target"})

This seems to be a problem with param annotations

@TheDan64 TheDan64 added bug Something isn't working refactorer This issue relates to the refactoring tool labels Aug 26, 2019
@rinon rinon self-assigned this Sep 3, 2019
@rinon
Copy link
Contributor

rinon commented Sep 3, 2019

This was fixed upstream in rust-lang/rust@dd98727 but we can't roll to the new nightly yet due to changes in the pretty printer API. Will see if we can get more visibility for the pretty printer.

@rinon
Copy link
Contributor

rinon commented Sep 26, 2019

Waiting on #165

@rinon rinon added the blocked Cannot be supported without external support first label Sep 26, 2019
@TheDan64
Copy link
Contributor Author

@rinon this is fixed now, right?

@rinon
Copy link
Contributor

rinon commented Oct 16, 2019

Yeah

@rinon rinon closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Cannot be supported without external support first bug Something isn't working refactorer This issue relates to the refactoring tool
Projects
None yet
Development

No branches or pull requests

2 participants