Roll to nightly 2019-09-... #165
Conversation
|
Blocked until rust-lang/rust#64793 lands upstream. |
|
@TheDan64 The upgrade_ptr_to_ref test is failing, probably because the node ids are all wrong. |
|
Make that the |
|
Would like to push this to |
|
Please, if possible, check if rust-lang/rust-clippy#4590 is included. Since running clippy is a common task after the conversion is done, it's important to not let it fail. |
Whitespace changed in the new compiler version
We really should make this test more robust so we don't have to update node ids when the AST changes slightly.
This depends on rust-lang/rust#64793 landing upstream.
As of commit a88d181a023e in rustc, HIR and Ty level IR no longer carries the variadic dummy param, so we don't need to subtract 1 from the number of arguments.
|
Last buildable nightly toolchain with that ICE fix landed is |
…irectly to fix structure.rs tests
…ss_check attribute instead of crate-level inner attribute
Something changed in the compiler between 2019-10-04 and 2019-10-13 that broke one of our tests. I don't have time to fix it right now, so I'm going to merge this. We can revisit rolling to something newer if/when it is needed. |
We need proper support for parameter attributes, which requires a newer nightly.
I split out the rustc/libsyntax pretty-printer into our own crate so we can once again forge a list of comments to be emitted in the pretty-printed output. It seemed to invasive to request this change upstream, and the pretty-printer should be easy to maintain out-of-tree.