Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust nightly version #1114

Closed
wants to merge 3 commits into from

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Aug 28, 2024

Closing #1098 would be easiest if we didn't have to cater for the very old nightly. Let's try updating that first.

This fixes trouble with old proc-macro2 on new nightlies.
The current nightly supports the latest time-macros (by a long time).
Not pinning again because more recent cargo versions can take care of
rust-version metadata in crates.
@kkysen
Copy link
Contributor

kkysen commented Aug 28, 2024

Hi! We have an old PR #811 that updated to 1.67, though it's old and needs rebasing. If you'd rather, you could rebase that. That said, I'm gonna fix the issue by just removing git-testament for now, which removes the time dependency entirely. It's nice to have, so if we update the nightly later, we'll add it back, but that should be pretty simple.

@chrysn
Copy link
Contributor Author

chrysn commented Aug 28, 2024

Thanks for the pointer. Yeah, during the build tests I've run into things you've already solved there.

I'll see if I have anything to contribute there (looks active, which is great), and close this one.

If having some outside testing of the git-testament removal helps, I'd be more than happy to run the full RIOT test suite over that PR once it is there. (Or is that just the plan and nobody is working on it? I can give it a jab, especially if that contributes to getting a new released c2rust that can be cargo installed again in the next few days.)

@chrysn chrysn closed this Aug 28, 2024
@kkysen
Copy link
Contributor

kkysen commented Aug 28, 2024

I'm in the middle of it and I'll put up a PR for it shortly. If you can test it extensively, that'd be great! (Though I don't anticipate problems with time gone). Then we'll make a new release right after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants