WIP: Support C11 atomics required by dav1d #814
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedataking
force-pushed
the
perl/c11_atomics
branch
from
a3bff0f
to
ce04e4e
Compare
As atomics are being implemented, these warnings are becoming wrong. Any operations on atomics that stay unimplmented will be caught more precisely at later translation stages.
thedataking
force-pushed
the
perl/c11_atomics
branch
from
ce04e4e
to
d84fa89
Compare
thedataking
force-pushed
the
perl/c11_atomics
branch
from
d84fa89
to
042845b
Compare
rinon
reviewed
Mar 7, 2023
| @@ -363,7 +365,7 @@ class TypeEncoder final : public TypeVisitor<TypeEncoder> { | |||
| } | |||
| }(); | |||
| // All the SVE types present in Clang 10 are 128-bit vectors | |||
| // (see `AArch64SVEACLETypes.def`), so we can divide 128 | |||
| @@ -403,7 +405,7 @@ class TypeEncoder final : public TypeVisitor<TypeEncoder> { | |||
| // Constructed as a consequence of the conversion of | |||
| // built-in to normal vector types. | |||
| case BuiltinType::Float16: return TagHalf; | |||
| case BuiltinType::Half: return TagHalf; | |||
| @@ -1756,6 +1766,11 @@ impl ConversionContext { | |||
| let typ = node.type_id.expect("Expected expression to have type"); | |||
| let typ = self.visit_qualified_type(typ); | |||
|
|
|||
| // Perhaps as an optimization since atomic_init has no order, | |||
There was a problem hiding this comment.
We should really define a fixed operand ordering here in our interchange format, but this technically works.
| "__atomic_compare_exchange" | "__atomic_compare_exchange_n" => { | ||
| "__atomic_compare_exchange" | ||
| | "__atomic_compare_exchange_n" | ||
| | "__c11_atomic_compare_exchange_strong" => { |
Comment on lines
+213
to
+215
| // TODO(perl): __c11_atomic_compare_exchange_strong does not | ||
| // seem to produce correct code. It produces a deref operation | ||
| // on the `src` argument to atomic_cxchg_seqcst_seqcst. |
There was a problem hiding this comment.
If it doesn't produce correct code then why are we handling it at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.