Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages for Node 18 #3

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Update packages for Node 18 #3

merged 7 commits into from
Nov 14, 2022

Conversation

iancamp
Copy link

@iancamp iancamp commented Nov 10, 2022

I encountered a few issues and a bunch of warnings about super old packages during my node 18 upgrade. This PR updates most of the dependencies which resolved the issues I encountered. I didn't try too hard to upgrade Lodash since the adapter code tends to swallow a lot of errors (due lack of callback(error) calls), which makes debugging painful.

I also upgraded the engine to 18 since that's what I used to test, but can change it back if needed.

Copy link

@jeffmhastings jeffmhastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iancamp iancamp merged commit b51e933 into immuta Nov 14, 2022
@iancamp iancamp deleted the update-packages branch November 14, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants