This repository was archived by the owner on Jul 23, 2021. It is now read-only.
This repository was archived by the owner on Jul 23, 2021. It is now read-only.
Investigate performance regression in fromJS() #212
Closed
Description
See #210 for why this issue exists.
See #211 for the code used in the benchmark.
Note Lee's thoughts when someone proposed our current solution:
- fromJS() only works on Objects in the same Realm immutable-js/immutable-js#1039
Immutable.fromJS
bug with no classes objects with custom constructor property immutable-js/immutable-js#1056
Thought so far:
- Is this the most performant way to get the correct behavior? If so, do we just go with it? Or do we just not support objects in separate realms?
- What other options are available to us?
Metadata
Metadata
Assignees
Labels
No labels