Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generalise useExecute hook #2493

Merged
merged 6 commits into from
Jan 10, 2025
Merged

refactor: generalise useExecute hook #2493

merged 6 commits into from
Jan 10, 2025

Conversation

mimi-imtbl
Copy link
Contributor

@mimi-imtbl mimi-imtbl commented Jan 10, 2025 •
edited
Loading

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Refactor useExecute hook to be used in both Add Tokens and Purchase widgets.

  • Move Add Tokens error handling out of useExecute by providing onTransactionError callback
  • Move Add Tokens event tracking out of useExecute

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 15511d3.

Command Status Duration Result
nx affected -t build,lint,test,typecheck ✅ Succeeded 5m 25s View ↗
nx run-many --target=build --projects=@imtbl/sdk ✅ Succeeded 3m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-10 02:54:31 UTC

@mimi-imtbl mimi-imtbl changed the title Refactor/use execute hook refactor: generalise useExecute hook Jan 10, 2025
@mimi-imtbl mimi-imtbl marked this pull request as ready for review January 10, 2025 02:48
@mimi-imtbl mimi-imtbl requested a review from a team as a code owner January 10, 2025 02:48
@mimi-imtbl mimi-imtbl added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit dbb0606 Jan 10, 2025
8 checks passed
@mimi-imtbl mimi-imtbl deleted the refactor/useExecute-hook branch January 10, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luads luads luads approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimi-imtbl @luads