docs: add documentation to passport methods #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YermekG
reviewed
Oct 15, 2024
YermekG
reviewed
Oct 16, 2024
ImmutableJeffrey
force-pushed
the
docs/dx-2515
branch
from
433d7bf
to
81a8d8e
Compare
YermekG
approved these changes
Oct 16, 2024
nattb8
reviewed
Oct 16, 2024
| * Logs the user into Passport via device code auth and sets up the Immutable X provider. | ||
| * | ||
| * This will open the user's default browser and take them through Passport login. | ||
| * @param IsConnectImx If true, the "re-connect" method is used to authenticate into Passport with Immutable X. |
There was a problem hiding this comment.
This one is quite confusing because it if this then that, then an if becomes another if else. Maybe split it into Immutable X: xxx
Immutable zkEVM: xxx
There was a problem hiding this comment.
This is a part of the game bridge code. I tried to state what happens inside the game bridge when you reconnect.
There was a problem hiding this comment.
I am not sure how else it should be stated
ImmutableJeffrey
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit 039edd3.
YermekG
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add documentation to passport methods
feat:,fix:,chore:,docs:,refactor:ortest:.