Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris build failure #42

Open
rstub opened this issue May 14, 2018 · 2 comments
Open

Solaris build failure #42

rstub opened this issue May 14, 2018 · 2 comments

Comments

@rstub
Copy link

rstub commented May 14, 2018

I have incorporated the PCG family into an R package. On submission to CRAN I have been informed about a compilation error on Solaris:

In file included from dqrng.cpp:22:0:
../inst/include/pcg_random.hpp:1639:18: error: reference to ‘extended’ is ambiguous
using ext_std8 = extended<table_pow2, advance_pow2, BaseRNG,
^
In file included from /usr/include/math.h:382:0,
from /opt/csw/include/c++/5.2.0/cmath:44,
from /home/ripley/R/Lib32/Rcpp/include/Rcpp/platform/compiler.h:100,
from /home/ripley/R/Lib32/Rcpp/include/Rcpp/r/headers.h:48,
from /home/ripley/R/Lib32/Rcpp/include/RcppCommon.h:38,
from /home/ripley/R/Lib32/Rcpp/include/Rcpp.h:27,
from dqrng.cpp:18:
/usr/include/floatingpoint.h:71:18: note: candidates are: typedef unsigned int extended [3]
typedef unsigned extended[3];
^

I was able to circumvent this with a simple patch to use fully qualified names. Are you interested in a PR based on this patch?

@vedranmiletic
Copy link

Can confirm on:

$ uname -a
SunOS arno 5.11 omnios-r151032-702376803e i86pc i386 i86pc
$ gcc --version
gcc (OmniOS 151032/8.3.0-il-0) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

vedranmiletic added a commit to rxdock/rxdock that referenced this issue Nov 24, 2019
PCG fails to build on Solaris. Use instead whatever the compiler and
the standard library provide as the default C++11 RNG.

Issue on GitHub: imneme/pcg-cpp#42
vedranmiletic added a commit to rxdock/rxdock that referenced this issue Nov 24, 2019
PCG fails to build on Solaris and Windows/MSVC. Use instead whatever the
compiler and the standard library provide as the default C++11 RNG.

Issues on GitHub:
- Solaris: imneme/pcg-cpp#42
- Windows/MSVC: imneme/pcg-cpp#11
vedranmiletic added a commit to rxdock/rxdock that referenced this issue Dec 5, 2019
PCG fails to build on Solaris and Windows/MSVC. Use instead whatever the
compiler and the standard library provide as the default C++11 RNG.

Issues on GitHub:
- Solaris: imneme/pcg-cpp#42
- Windows/MSVC: imneme/pcg-cpp#11
vedranmiletic added a commit to rxdock/rxdock that referenced this issue May 3, 2020
PCG fails to build on Solaris and Windows/MSVC. Use instead whatever the
compiler and the standard library provide as the default C++11 RNG.

Issues on GitHub:
- Solaris: imneme/pcg-cpp#42
- Windows/MSVC: imneme/pcg-cpp#11
@hannes
Copy link

hannes commented Mar 10, 2021

Ran into this as well. The simplest fix is to rename the extended template to something else, like pcg_extended.

vedranmiletic added a commit to rxdock/rxdock that referenced this issue Jun 9, 2021
PCG fails to build on Solaris and Windows/MSVC. Use instead whatever the
compiler and the standard library provide as the default C++11 RNG.

Issues on GitHub:
- Solaris: imneme/pcg-cpp#42
- Windows/MSVC: imneme/pcg-cpp#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants