Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Add "Fork me on GitHub ribbon" #17

Closed
dietmarw opened this issue Sep 26, 2015 · 5 comments
Closed

Add "Fork me on GitHub ribbon" #17

dietmarw opened this issue Sep 26, 2015 · 5 comments

Comments

@dietmarw
Copy link
Member

I think it would be a good idea to add a "Fork me on GitHub" ribbon. I found https://github.com/simonwhitaker/github-fork-ribbon-css which makes this rather lightweight and via css only.

I would go for a simple black, bottom right variant.

@xogeny
Copy link

xogeny commented Sep 28, 2015

Where? Do you want this on the web application itself? (encouraging people to fork the web application?) Or do you mean in the detailed listing of each library?

All this presumes that the library is on GitHub. This is again (like #6 and #18) an issue with the index because it must be spelled out very clearly in the index that a) forking is possible and b) how that is done. The client may be showing results from multiple sources (not necessarily GitHub) so we need to abstract these things out. The best way to handle that is to include (optional) information in the index.

@dietmarw
Copy link
Member Author

I was actually only thinking of the "search" project itself. Because I got questions from people where the source is.

@dietmarw dietmarw self-assigned this Sep 29, 2015
xie-dongping added a commit to xie-dongping/search that referenced this issue Oct 3, 2015
xogeny pushed a commit that referenced this issue Oct 4, 2015
"Fork me on Github" ribbon to address issue #17 

Very cool.  Thanks.
@xogeny
Copy link

xogeny commented Oct 4, 2015

This was added in #24. However, there is a lingering issue. On mobile (at least on my iPhone), the ribbon doesn't reach the right margin.

@xie-dongping
Copy link
Contributor

I can confirm the issue using an iPhone. However, since I have no Mac, I cannot use debug mode on iOS.

Rant: So Apple forcing every mobile developer to buy a Mac.

@dietmarw
Copy link
Member Author

dietmarw commented Mar 2, 2020

Tested it with FF developer mode emulating different iPhones and it seems to work as expected. So closing for now.

@dietmarw dietmarw closed this as completed Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants