Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPCT1-483] - delete pending community #124

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

dev-jotape
Copy link
Collaborator

@dev-jotape dev-jotape commented Oct 7, 2021

This PR fixes [IPCT1-483] at https://impactmarket.atlassian.net/browse/IPCT1-483

Changes

New

new endpoint that able a user to delete a pending submission

Tests

new tests added on community.test.ts

@dev-jotape dev-jotape marked this pull request as ready for review October 7, 2021 15:03
@dev-jotape dev-jotape changed the title [IPCT1-485] - delete community pending [IPCT1-485] - delete pending community Oct 7, 2021
@dev-jotape dev-jotape changed the title [IPCT1-485] - delete pending community [IPCT1-483] - delete pending community Oct 8, 2021
Copy link
Contributor

@vibern0 vibern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry 🤦 My review was pending 🤦 🤦 🤦 🤦 🤦

tests/integration/services/community.test.ts Outdated Show resolved Hide resolved
Comment on lines 1450 to 1472
const community = await CommunityService.create(
users[0].address,
'Community test',
undefined,
'community test',
'pt',
'BRL',
'Rio de Janeiro',
'Brazil',
{
latitude: 0,
longitude: 0,
},
'example@me.io',
undefined,
{
claimAmount: '1500000000000000000',
maxClaim: '400000000000000000000',
baseInterval: 86400,
incrementInterval: 600,
},
mediaContent.id
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the factory?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know why I did it that way....
but I changed to factory

João Pedro and others added 2 commits October 13, 2021 10:36
Co-authored-by: Bernardo Vieira <bernardo@impactmarket.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vibern0 vibern0 merged commit 4bba49d into master Oct 14, 2021
@vibern0 vibern0 deleted the feature/delete-community-submission branch October 14, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants