Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPCT1-468] - define default offset and limit #133

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

dev-jotape
Copy link
Collaborator

This PR fixes [IPCT1-468] at https://impactmarket.atlassian.net/browse/IPCT1-468

Changes

New

added in config the defaultLimit and defaultOffset to use in endpoints with offset and limit were not specified.

Tests

all tests passed

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dev-jotape dev-jotape marked this pull request as ready for review October 20, 2021 22:17
@dev-jotape dev-jotape changed the title [PCT1-468] - define default offset and limit [IPCT1-468] - define default offset and limit Oct 21, 2021
@vibern0 vibern0 merged commit 42743ef into master Oct 22, 2021
@vibern0 vibern0 deleted the feature/default-offset-limit branch October 22, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants