[IPCT1-486] - replace community state #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2021 22:30
dev-jotape
force-pushed
the
refactor/community-state
branch
from
7f61d04
to
645ec14
Compare
dev-jotape
force-pushed
the
refactor/community-state
branch
from
25e92c0
to
44a671f
Compare
vibern0
suggested changes
Nov 23, 2021
|
@obernardovieira ready to review |
vibern0
reviewed
Dec 3, 2021
| @@ -40,18 +40,18 @@ | |||
| * description: Number of unique backers since contract inception | |||
| */ | |||
| export interface UbiCommunityState { | |||
There was a problem hiding this comment.
remove all instances of the community state table
There was a problem hiding this comment.
but do not add a drop table yet (needs to be at a later stage)
There was a problem hiding this comment.
done!
I kept only the interface
Comment on lines
30
to
33
| -- SELECT SUM(raised + NEW.amount) INTO state_raised FROM ubi_community_state WHERE "communityId"=community_id; | ||
| -- UPDATE ubi_community_state SET raised = state_raised WHERE "communityId"=community_id; | ||
| -- SELECT SUM(raised + NEW.amount) INTO state_daily_raised FROM ubi_community_daily_state WHERE "communityId"=community_id AND date=DATE(NEW."txAt"); | ||
| -- UPDATE ubi_community_daily_state SET raised = state_daily_raised WHERE "communityId"=community_id AND date=DATE(NEW."txAt"); |
There was a problem hiding this comment.
removed unused lines on this file
|
Feels like we are getting to the other side of the tunnel 👀 |
added 2 commits
December 3, 2021 23:06
|
Kudos, SonarCloud Quality Gate passed!
|
vibern0
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes [IPCT1-486] at https://impactmarket.atlassian.net/browse/IPCT1-486
Changes
removed triggers on tables:
edited triggers on table:
changed get community state to get the previous state + today's state
New
Tests