Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPCT1-509] - Media path #207

Merged
merged 7 commits into from
Mar 16, 2022
Merged

[IPCT1-509] - Media path #207

merged 7 commits into from
Mar 16, 2022

Conversation

dev-jotape
Copy link
Collaborator

@dev-jotape dev-jotape commented Feb 27, 2022 •
edited
Loading

This PR fixes [IPCT1-509] at https://impactmarket.atlassian.net/browse/IPCT1-509

Changes

Change services to use mediaPath instead mediaId.
When an image is uploaded, just save the image path

Tests

all tests running

@dev-jotape dev-jotape marked this pull request as ready for review February 28, 2022 21:27
@dev-jotape dev-jotape removed the request for review from vibern0 February 28, 2022 21:51
@dev-jotape dev-jotape marked this pull request as draft February 28, 2022 21:52
@dev-jotape dev-jotape marked this pull request as ready for review March 4, 2022 15:10
@dev-jotape dev-jotape requested a review from vibern0 March 4, 2022 15:11
vibern0
vibern0 reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@vibern0 vibern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for routes and validators, leave only the mediaId, don't add mediaPth nor document it yet.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vibern0 vibern0 merged commit 88c4153 into main Mar 16, 2022
@vibern0 vibern0 deleted the media-path branch March 30, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibern0 vibern0 vibern0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-jotape @vibern0