[IPCT1-743] - use the graph subscriptions to add notification #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jotape
force-pushed
the
thegraph-subscription
branch
from
5c09d3b
to
b0814b5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vibern0
reviewed
Jul 1, 2022
Comment on lines
+33
to
+37
| where: { | ||
| startDayId_gte: ${ | ||
| (new Date().getTime() / 1000 / 86400) | 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
won't this make users get notified twice if the server is restarted?
There was a problem hiding this comment.
as there is no DateTime field, only the day, just below there is a check to see if there is already a notification created for the community, just to avoid a situation like this of the server restarting and users being notified of the communities opened today
vibern0
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes [IPCT1-743] at https://impactmarket.atlassian.net/browse/IPCT1-743
Changes
use the graph subscription to add notification.
Tests