Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

351 - refactor pending community #353

Merged
merged 6 commits into from
Jul 29, 2022
Merged

351 - refactor pending community #353

merged 6 commits into from
Jul 29, 2022

Conversation

dev-jotape
Copy link
Collaborator

@dev-jotape dev-jotape commented Jul 19, 2022 •
edited
Loading

This PR fixes #351

Changes

  • fix list communities by ambassador
  • add new contract fields (minTranche, maxTranche) and able to edit
  • use float values, human-readable, instead of big numbers with 18 decimals. Make sure it doesn't break the app.

Tests

all tests passed

@dev-jotape dev-jotape force-pushed the 351-refactor-pending-community branch from 4d6c4f6 to ef99051 Compare July 22, 2022 23:22
@dev-jotape dev-jotape marked this pull request as ready for review July 25, 2022 12:33
@dev-jotape dev-jotape requested a review from vibern0 July 25, 2022 12:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vibern0
vibern0 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@vibern0 vibern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 💪

@dev-jotape dev-jotape merged commit 581cb7a into main Jul 29, 2022
@dev-jotape dev-jotape deleted the 351-refactor-pending-community branch July 29, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibern0 vibern0 vibern0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor pending community details
2 participants
@dev-jotape @vibern0