Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[357] - refactor filter managers/beneficiaries by state #373

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

dev-jotape
Copy link
Collaborator

This PR fixes #357

Changes

Refactor filter managers/beneficiaries by state.
Instead of using active, removed and locked, use 0 (active), 1 (removed) and 2 (locked).
The endpoint response was changed too.

Tests

@dev-jotape dev-jotape requested a review from vibern0 August 1, 2022 18:06
@dev-jotape
Copy link
Collaborator Author

@obernardovieira , after validation, please don't merge, I need to align with the front-end team the deploy

Co-authored-by: Bernardo Vieira <bernardo@impactmarket.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dev-jotape dev-jotape merged commit 3334d6f into main Aug 17, 2022
@dev-jotape dev-jotape deleted the 357-filter-beneficiary-by-state branch August 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter beneficiary by state (when listing beneficiaries) instead of only active/inactive. To include blocked
2 participants