Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter beneficiaries by inactivity #704

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

dev-jotape
Copy link
Collaborator

@dev-jotape dev-jotape commented Jun 29, 2023

This PR fixes #673

Changes

add the lastActivity_lt query field (the same used on TheGraph) to specify a timestamp to filter "inactive" beneficiaries.
Inactive beneficiaries are beneficiaries with the state "active" that didn't have any activity in the last X days (X is defined by the lastActivity_lt).

Tests

@dev-jotape dev-jotape requested a review from vibern0 June 29, 2023 18:18
@dev-jotape dev-jotape marked this pull request as draft June 30, 2023 23:38
@dev-jotape dev-jotape marked this pull request as ready for review June 30, 2023 23:38
Bernardo Vieira added 2 commits July 7, 2023 12:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.4% 2.4% Duplication

@vibern0 vibern0 merged commit 5b73a25 into main Jul 7, 2023
@vibern0 vibern0 deleted the feature/filter-inactive-beneficiaries branch July 7, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp: Active / Inactive Beneficiaries - if I click view All, I am redirected to the Beneficiaries main page
2 participants