Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix get notifications + update endpoints #761

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

vibern0
Copy link
Contributor

@vibern0 vibern0 commented Jul 21, 2023

Changes

This PR fixes the endpoint to get notifications. It also removes the get endpoint to get only the unread, merging into only one endpoint, with a query parameter of unreadOnly.

Tests

@vibern0 vibern0 requested a review from dev-jotape July 21, 2023 16:35
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vibern0 vibern0 merged commit f7c6361 into main Jul 24, 2023
3 checks passed
@vibern0 vibern0 deleted the fix/get-notifications branch July 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants