Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] load and select loan manager to form #770

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

vibern0
Copy link
Contributor

@vibern0 vibern0 commented Jul 25, 2023

This PR fixes #758

Changes

This PR add functionality to load and select a loan manager.
To load user GET /microcredit/managers/{country} where country can be "ug" for Uganda for example. This will load the loan manager profile.
To save the loan manager, the POST /microcredit/form was changed. It is now possible to send just the prismicId and selectedLoanManagerId (which should be the user id from the endpoint above) or the prismicId the from and submitted.

Tests

no new tests

@vibern0 vibern0 requested a review from dev-jotape July 25, 2023 14:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vibern0 vibern0 requested review from dev-jotape and removed request for dev-jotape July 25, 2023 14:44
@dev-jotape dev-jotape merged commit c806447 into main Jul 25, 2023
1 check passed
@dev-jotape dev-jotape deleted the feature/select-loan-manager branch July 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MicroCredit] select loan manager
2 participants