[feature] send push notification when user receives a transfer #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibern0
suggested changes
Aug 24, 2023
| @@ -57,7 +57,8 @@ export enum NotificationParamsPath { | |||
| STORY = 'stories?id=', | |||
| COMMUNITY = 'communities/', | |||
| LOAN_APPLICATION = 'microcredit/form/', | |||
| LOAN_APPROVED = 'microcredit/' | |||
| LOAN_APPROVED = 'microcredit/', | |||
| TRANSACTION_RECEIVED = 'transactions/' | |||
There was a problem hiding this comment.
You don't need this. This matters only if were to send the user somewhere, but we will only open a bottom-sheet on the wallet, using the transactionHash
|
|
||
| // send push notification | ||
| if (user) | ||
| sendNotification([user], NotificationType.TRANSACTION_RECEIVED, true, true, { |
There was a problem hiding this comment.
This notification requires something new. We need to get the "amount" and token name and send that together on the notification.
The notification will be something like "You've just received {{amount}} {{currency}}.", and replace "amount" and "currency" before sending the notification.
There was a problem hiding this comment.
done, please can you review it again?
vibern0
approved these changes
Aug 31, 2023
Co-authored-by: Bernardo Vieira <bernardo@impactmarket.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #744
Changes
Send push notification when a user receives a transfer from the following assets: cUSD, cEUR, cREAL, CELO, and PACT.
Tests