Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Bencher CLI GitHub Action #12

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Move to Bencher CLI GitHub Action #12

merged 2 commits into from
Dec 1, 2023

Conversation

epompeii
Copy link
Collaborator

Move Bencher in CI over to the Bencher CLI GitHub Action.

Also add a Bencher perf image to the readme to illustrate the similarities in performance for log4rs vs trace4rs.

@epompeii
Copy link
Collaborator Author

epompeii commented Mar 19, 2023

Is BENCHER_API_TOKEN still set as a repository secret?

I sanity checked by running a nearly identical test on my own repo and things worked:

And on the PR branch as well:

I also checked the API token locally, and it is still valid and working.

@epompeii
Copy link
Collaborator Author

epompeii commented Mar 21, 2023

I believe what is happening is because I don't have the appropriate permissions on the repository GitHub is not actually providing the secret. This is in order to prevent randos from being able to leak/exfiltrate repository secrets.

error: a value is required for '--token <TOKEN>' but none was supplied

https://github.com/imperva/trace4rs/actions/runs/4479249673/jobs/7872979410?pr=13

@epompeii epompeii force-pushed the bencher branch 2 times, most recently from 52df886 to 5d78b0b Compare November 27, 2023 20:23
@gadunga
Copy link
Collaborator

gadunga commented Nov 28, 2023

I'll take a look at the settings and send you a message.

@gadunga
Copy link
Collaborator

gadunga commented Nov 28, 2023

It appears that I do not have access to that. We'll need to talk to someone about getting access to that.

@estk estk merged commit bf13422 into imperva:main Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants