Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track the status of offers and credentials #133

Merged
merged 99 commits into from
Nov 29, 2024

Conversation

nanderstabel
Copy link
Collaborator

Description of change

As title.

Also this PR introduces some slight refactor:
For both the Offer and Credential aggregates the corresponding OfferView and CredentialView are moved from the queries folder to the new views folder.

Blocked by

Links to any relevant issues

How the change has been tested

Updated existing unit tests

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel requested review from Oran-Dan and removed request for daniel-mader November 26, 2024 10:10
@daniel-mader daniel-mader changed the title feat: add Status field to Issuance's Offer and Credential aggregates feat: add a status (Pending, Issued) to offers and credentials Nov 27, 2024
@daniel-mader daniel-mader changed the title feat: add a status (Pending, Issued) to offers and credentials feat: add a status (Created, Pending, Issued) to offers and credentials Nov 27, 2024
@daniel-mader daniel-mader changed the title feat: add a status (Created, Pending, Issued) to offers and credentials feat: track the status for offers and credentials: Created, Pending, Issued Nov 27, 2024
Base automatically changed from nanderstabel/issue125 to beta November 28, 2024 09:24
@nanderstabel nanderstabel changed the title feat: track the status for offers and credentials: Created, Pending, Issued feat: track the status for offers and credentials Nov 28, 2024
@daniel-mader daniel-mader changed the title feat: track the status for offers and credentials feat: track the status of offers and credentials Nov 29, 2024
@nanderstabel nanderstabel merged commit d55158e into beta Nov 29, 2024
2 checks passed
@nanderstabel nanderstabel deleted the nanderstabel/issue119 branch November 29, 2024 10:15
Copy link

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants