-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track the status of offers and credentials #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
requested review from
Oran-Dan
and removed request for
daniel-mader
November 26, 2024 10:10
daniel-mader
changed the title
feat: add Status field to Issuance's Offer and Credential aggregates
feat: add a status (Nov 27, 2024
Pending
, Issued
) to offers and credentials
daniel-mader
changed the title
feat: add a status (
feat: add a status (Nov 27, 2024
Pending
, Issued
) to offers and credentialsCreated
, Pending
, Issued
) to offers and credentials
daniel-mader
changed the title
feat: add a status (
feat: track the status for offers and credentials: Nov 27, 2024
Created
, Pending
, Issued
) to offers and credentialsCreated
, Pending
, Issued
nanderstabel
changed the title
feat: track the status for offers and credentials:
feat: track the status for offers and credentials
Nov 28, 2024
Created
, Pending
, Issued
daniel-mader
changed the title
feat: track the status for offers and credentials
feat: track the status of offers and credentials
Nov 29, 2024
daniel-mader
approved these changes
Nov 29, 2024
🎉 This PR is included in version 1.0.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As title.
Also this PR introduces some slight refactor:
For both the
Offer
andCredential
aggregates the correspondingOfferView
andCredentialView
are moved from thequeries
folder to the newviews
folder.Blocked by
Connection
aggregate #131Links to any relevant issues
status
field toCredential
andOffer
aggregates inagent_issuance
#119How the change has been tested
Updated existing unit tests
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.