fix: fix panic on missing issuer_key_id in agent_issuance
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
force-pushed
the
fix/default-test-stronghold
branch
from
a74d2cf to
b761d77
Compare
daniel-mader
approved these changes
Apr 12, 2024
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There was a panic in
agent_issuancewhen the 'optional'AGENT_SECRET_MANAGER_ISSUER_KEY_IDenvironment variable was not set. This change fixes that by setting it by default and mount thetest.strongholdfile by default.Links to any relevant issues
How the change has been tested
Manually tested and tested using the Postman Collection.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.