Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for OpenID4VP #53

Merged
merged 10 commits into from
May 13, 2024
Merged

feat: add support for OpenID4VP #53

merged 10 commits into from
May 13, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented May 9, 2024

Description of change

See title

Links to any relevant issues

#22

How the change has been tested

Added and improved aggregate tests.

How to manually test this change:

  1. Simply run UniCore (cargo run)
  2. Run UniMe on a physical device using this branch: chore: bump oid4vc dependencies identity-wallet#197
  3. Use the Postman collection to send both the /v1/credentials request and the /v1/offers request.
  4. Render the encoded string that is returned as a QR code.
  5. Scan the QR code with UniMe and accept the offer
  6. Use the Postman collection to send the v1/authorization_request request.
  7. Render the encoded string that is returned as a QR code.
  8. Scan the QR code and accept the Authorization Request
  9. UniCore will successfully verify UniMe's Authorization Response

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
scala-steward Scala Steward
@nanderstabel nanderstabel added the Added A new feature that requires a minor release. label May 9, 2024
@nanderstabel nanderstabel self-assigned this May 9, 2024
@nanderstabel nanderstabel marked this pull request as ready for review May 9, 2024 16:10
@nanderstabel nanderstabel requested a review from daniel-mader May 13, 2024 19:55
…sEndpointRequest`
@nanderstabel nanderstabel merged commit e581d45 into dev May 13, 2024
1 check passed
@nanderstabel nanderstabel deleted the feat/oid4vp branch May 13, 2024 20:05
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. released on @alpha released on @beta
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants