Skip to content

perf: disable throwIfNoEntry on Node 14+ #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2022
Merged

perf: disable throwIfNoEntry on Node 14+ #182

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07258ff
perf: use throwIfNoEntry on Node 14+
chenxinyanc Sep 7, 2022
8c3dff0
Create cyan-parrots-act.md
JounQin Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ function removeQuerystring(id: string) {

const isFile = (path?: string | undefined): path is string => {
try {
return !!path && fs.statSync(path).isFile()
return !!(path && fs.statSync(path, { throwIfNoEntry: false })?.isFile())
} catch {
// Node 12 does not support throwIfNoEntry.
return false
}
}
Expand Down