prefer-default-export: don't warn on TypeAlias & TSTypeAliasDeclaration

Fixes #1332.
import-js · Jul 17, 2019 · 078d712 · 078d712
1 parent 22d5440
commit 078d712
Show file tree

Hide file tree

Showing 2 changed files with 73 additions and 3 deletions.
diff --git a/src/rules/prefer-default-export.js b/src/rules/prefer-default-export.js
@@ -47,9 +47,16 @@ module.exports = {
         // if there are specifiers, node.declaration should be null
         if (!node.declaration) return
 
-        // don't count flow types exports
+        // don't warn on single type aliases or declarations
         if (node.exportKind === 'type') return
 
+        if (
+          node.declaration.type === 'TSTypeAliasDeclaration' ||
+          node.declaration.type === 'TypeAlias'
+        ) {
+          return
+        }
+
         if (node.declaration.declarations) {
           node.declaration.declarations.forEach(function(declaration) {
             captureDeclaration(declaration.id)

diff --git a/tests/src/rules/prefer-default-export.js b/tests/src/rules/prefer-default-export.js
@@ -1,6 +1,8 @@
 import { test } from '../utils'
 
 import { RuleTester } from 'eslint'
+import eslintPkg from 'eslint/package.json'
+import semver from 'semver'
 
 const ruleTester = new RuleTester()
     , rule = require('rules/prefer-default-export')
@@ -83,7 +85,6 @@ ruleTester.run('prefer-default-export', rule, {
       code: 'export { a, b } from "foo.js"',
       parser: require.resolve('babel-eslint'),
     }),
-
     // ...SYNTAX_CASES,
   ],
   invalid: [
@@ -129,4 +130,66 @@ ruleTester.run('prefer-default-export', rule, {
       }],
     }),
   ],
-})
+});
+
+context('Typescript', function() {
+  // Typescript
+  const parsers = ['babel-eslint'];
+
+  if (semver.satisfies(eslintPkg.version, '<6.0.0')) {
+    parsers.push('typescript-eslint-parser');
+  }
+
+  if (semver.satisfies(eslintPkg.version, '>5.0.0')) {
+    parsers.push('@typescript-eslint/parser');
+  }
+
+  parsers.forEach((parser) => {
+    const parserConfig = {
+      parser: parser,
+      settings: {
+        'import/parsers': { [parser]: ['.ts'] },
+        'import/resolver': { 'eslint-import-resolver-typescript': true },
+      },
+    };
+
+    ruleTester.run('prefer-default-export', rule, {
+      valid: [
+        // Exporting types
+        test(
+          {
+            code: `
+        export type foo = string;
+        export type bar = number;`,
+            parser,
+          },
+          parserConfig,
+        ),
+        test(
+          {
+            code: `
+        export type foo = string;
+        export type bar = number;`,
+            parser,
+          },
+          parserConfig,
+        ),
+        test(
+          {
+            code: 'export type foo = string',
+            parser,
+          },
+          parserConfig,
+        ),
+        test(
+          {
+            code: 'export type foo = string',
+            parser,
+          },
+          parserConfig,
+        ),
+      ],
+      invalid: [],
+    });
+  });
+});