Fix false positive with default import having a "default" property (f…

…ixes #507, closes #508)

CHANGELOG.md

@@ -4,8 +4,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).
 
 ## [Unreleased]
+### Added
 - Added an `allow` option to [`no-nodejs-modules`] to allow exceptions ([#452], [#509]).
 
+### Fixed
+- [`no-named-as-default-member`] Allow default import to have a property named "default" ([#507], thanks [@jquense])
+
 ## [1.14.0] - 2016-08-22
 ### Added
 - [`import/parsers` setting]: parse some dependencies (i.e. TypeScript!) with a different parser than the ESLint-configured parser. ([#503])
@@ -329,6 +333,7 @@ for info on changes for earlier releases.
 [#157]: https://github.com/benmosher/eslint-plugin-import/pull/157
 [#314]: https://github.com/benmosher/eslint-plugin-import/pull/314
 
+[#507]: https://github.com/benmosher/eslint-plugin-import/issues/507
 [#478]: https://github.com/benmosher/eslint-plugin-import/issues/478
 [#456]: https://github.com/benmosher/eslint-plugin-import/issues/456
 [#453]: https://github.com/benmosher/eslint-plugin-import/issues/453

src/rules/no-named-as-default-member.js

@@ -69,6 +69,10 @@ module.exports = function(context) {
       if (fileImport == null) return
 
       lookups.forEach(({propName, node}) => {
+        // the default import can have a "default" property
+        if (propName === 'default') {
+          return
+        }
         if (fileImport.exportMap.namespace.has(propName)) {
           context.report({
             node,

tests/files/default-export-default-property.js

@@ -0,0 +1,4 @@
+
+export default {
+  default: 'baz'
+}

tests/src/rules/no-named-as-default-member.js

@@ -10,6 +10,7 @@ ruleTester.run('no-named-as-default-member', rule, {
     test({code: 'import bar from "./bar"; const baz = bar.baz'}),
     test({code: 'import {foo} from "./bar"; const baz = foo.baz;'}),
     test({code: 'import * as named from "./named-exports"; const a = named.a'}),
+    test({code: 'import foo from "./default-export-default-property"; const a = foo.default'}),
 
     ...SYNTAX_CASES,
   ],