extensions: check importPath extension with a dot

import-js · Nov 21, 2016 · 3a03aca · 3a03aca
1 parent 523789f
commit 3a03aca
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/src/rules/extensions.js b/src/rules/extensions.js
@@ -96,7 +96,7 @@ module.exports = {
   create: function (context) {
 
     const props = buildProperties(context)
-    
+
     function getModifier(extension) {
       return props.pattern[extension] || props.defaultConfig
     }
@@ -131,11 +131,10 @@ module.exports = {
       const extension = path.extname(resolvedPath || importPath).substring(1)
 
       // determine if this is a module
-      const isPackageMain = 
-        isExternalModuleMain(importPath, context.settings) || 
-        isScopedMain(importPath)
+      const isPackageMain = isExternalModuleMain(importPath, context.settings)
+        || isScopedMain(importPath)
 
-      if (!extension || !importPath.endsWith(extension)) {
+      if (!extension || !importPath.endsWith(`.${extension}`)) {
         const extensionRequired = isUseOfExtensionRequired(extension, isPackageMain)
         const extensionForbidden = isUseOfExtensionForbidden(extension)
         if (extensionRequired && !extensionForbidden) {

diff --git a/tests/files/internal-modules/package.json b/tests/files/internal-modules/package.json
diff --git a/tests/files/node_modules/exceljs/excel.js b/tests/files/node_modules/exceljs/excel.js
diff --git a/tests/files/node_modules/exceljs/package.json b/tests/files/node_modules/exceljs/package.json
diff --git a/tests/src/rules/extensions.js b/tests/src/rules/extensions.js
@@ -1,6 +1,6 @@
 import { RuleTester } from 'eslint'
 import rule from 'rules/extensions'
-import { test } from '../utils'
+import { test, testFilePath } from '../utils'
 
 const ruleTester = new RuleTester()
 
@@ -59,7 +59,6 @@ ruleTester.run('extensions', rule, {
     test({ code: 'import thing from "./fake-file.js"', options: [ 'always' ] }),
     test({ code: 'import thing from "non-package"', options: [ 'never' ] }),
 
-
     test({
       code: `
         import foo from './foo.js'
@@ -90,6 +89,17 @@ ruleTester.run('extensions', rule, {
       options: [ 'never', {ignorePackages: true} ],
     }),
 
+    test({
+      code: 'import exceljs from "exceljs"',
+      options: [ 'always', { js: 'never', jsx: 'never' } ],
+      filename: testFilePath('./internal-modules/plugins/plugin.js'),
+      settings: {
+        'import/resolver': {
+          'node': { 'extensions': [ '.js', '.jsx', '.json' ] },
+          'webpack': { 'config': 'webpack.empty.config.js' },
+        },
+      },
+    }),
   ],
 
   invalid: [