Merge branch 'master' of github.com:benmosher/eslint-plugin-import in…

…to implement/rule/no-reaching-in

CHANGELOG.md

@@ -4,6 +4,21 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).
 
 ## [Unreleased]
+### Added
+- Added an `allow` option to [`no-nodejs-modules`] to allow exceptions ([#452], [#509]).
+- Added [`no-absolute-path`] rule ([#530], [#538])
+- [`max-dependencies`] for specifying the maximum number of dependencies (both `import` and `require`) a module can have. (see [#489], thanks [@tizmagik])
+- Added glob option to config for [`no-extraneous-dependencies`], after much bikeshedding. Thanks, [@knpwrs]! ([#527])
+
+### Fixed
+- [`no-named-as-default-member`] Allow default import to have a property named "default" ([#507]+[#508], thanks [@jquense] for both!)
+
+## [1.14.0] - 2016-08-22
+### Added
+- [`import/parsers` setting]: parse some dependencies (i.e. TypeScript!) with a different parser than the ESLint-configured parser. ([#503])
+
+### Fixed
+- [`namespace`] exception for get property from `namespace` import, which are re-export from commonjs module ([#499] fixes [#416], thanks [@wKich])
 
 ## [1.13.0] - 2016-08-11
 ### Added
@@ -258,6 +273,7 @@ for info on changes for earlier releases.
 [`import/cache` setting]: ./README.md#importcache
 [`import/ignore` setting]: ./README.md#importignore
 [`import/extensions` setting]: ./README.md#importextensions
+[`import/parsers` setting]: ./README.md#importparsers
 [`import/core-modules` setting]: ./README.md#importcore-modules
 [`import/external-module-folders` setting]: ./README.md#importexternal-module-folders
 
@@ -280,7 +296,19 @@ for info on changes for earlier releases.
 [`no-mutable-exports`]: ./docs/rules/no-mutable-exports.md
 [`prefer-default-export`]: ./docs/rules/prefer-default-export.md
 [`no-restricted-paths`]: ./docs/rules/no-restricted-paths.md
-
+<<<<<<< HEAD
+[`no-absolute-path`]: ./docs/rules/no-absolute-path.md
+=======
+[`max-dependencies`]: ./docs/rules/max-dependencies.md
+>>>>>>> tizmagik/feature/max-dependencies
+
+[#538]: https://github.com/benmosher/eslint-plugin-import/pull/538
+[#527]: https://github.com/benmosher/eslint-plugin-import/pull/527
+[#509]: https://github.com/benmosher/eslint-plugin-import/pull/509
+[#508]: https://github.com/benmosher/eslint-plugin-import/pull/508
+[#503]: https://github.com/benmosher/eslint-plugin-import/pull/503
+[#499]: https://github.com/benmosher/eslint-plugin-import/pull/499
+[#489]: https://github.com/benmosher/eslint-plugin-import/pull/489
 [#461]: https://github.com/benmosher/eslint-plugin-import/pull/461
 [#444]: https://github.com/benmosher/eslint-plugin-import/pull/444
 [#428]: https://github.com/benmosher/eslint-plugin-import/pull/428
@@ -317,11 +345,15 @@ for info on changes for earlier releases.
 [#157]: https://github.com/benmosher/eslint-plugin-import/pull/157
 [#314]: https://github.com/benmosher/eslint-plugin-import/pull/314
 
+[#530]: https://github.com/benmosher/eslint-plugin-import/issues/530
+[#507]: https://github.com/benmosher/eslint-plugin-import/issues/507
 [#478]: https://github.com/benmosher/eslint-plugin-import/issues/478
 [#456]: https://github.com/benmosher/eslint-plugin-import/issues/456
 [#453]: https://github.com/benmosher/eslint-plugin-import/issues/453
+[#452]: https://github.com/benmosher/eslint-plugin-import/issues/452
 [#441]: https://github.com/benmosher/eslint-plugin-import/issues/441
 [#423]: https://github.com/benmosher/eslint-plugin-import/issues/423
+[#416]: https://github.com/benmosher/eslint-plugin-import/issues/416
 [#415]: https://github.com/benmosher/eslint-plugin-import/issues/415
 [#386]: https://github.com/benmosher/eslint-plugin-import/issues/386
 [#373]: https://github.com/benmosher/eslint-plugin-import/issues/373
@@ -350,7 +382,8 @@ for info on changes for earlier releases.
 [#119]: https://github.com/benmosher/eslint-plugin-import/issues/119
 [#89]: https://github.com/benmosher/eslint-plugin-import/issues/89
 
-[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v1.13.0...HEAD
+[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v1.14.0...HEAD
+[1.14.0]: https://github.com/benmosher/eslint-plugin-import/compare/v1.13.0...v1.14.0
 [1.13.0]: https://github.com/benmosher/eslint-plugin-import/compare/v1.12.0...v1.13.0
 [1.12.0]: https://github.com/benmosher/eslint-plugin-import/compare/v1.11.1...v1.12.0
 [1.11.1]: https://github.com/benmosher/eslint-plugin-import/compare/v1.11.0...v1.11.1
@@ -408,3 +441,6 @@ for info on changes for earlier releases.
 [@rhettlivingston]: https://github.com/rhettlivingston
 [@zloirock]: https://github.com/zloirock
 [@rhys-vdw]: https://github.com/rhys-vdw
+[@wKich]: https://github.com/wKich
+[@tizmagik]: https://github.com/tizmagik
+[@knpwrs]: https://github.com/knpwrs

README.md

@@ -19,12 +19,14 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 * Ensure a default export is present, given a default import. ([`default`])
 * Ensure imported namespaces contain dereferenced properties as they are dereferenced. ([`namespace`])
 * Restrict which files can be imported in a given folder ([`no-restricted-paths`])
+* Forbid import of modules using absolute paths ([`no-absolute-path`])
 
 [`no-unresolved`]: ./docs/rules/no-unresolved.md
 [`named`]: ./docs/rules/named.md
 [`default`]: ./docs/rules/default.md
 [`namespace`]: ./docs/rules/namespace.md
 [`no-restricted-paths`]: ./docs/rules/no-restricted-paths.md
+[`no-absolute-path`]: ./docs/rules/no-absolute-path.md
 
 **Helpful warnings:**
 
@@ -52,6 +54,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`no-amd`]: ./docs/rules/no-amd.md
 [`no-nodejs-modules`]: ./docs/rules/no-nodejs-modules.md
 
+
 **Style guide:**
 
 * Ensure all imports appear before other statements ([`imports-first`])
@@ -61,6 +64,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 * Enforce a convention in module import order ([`order`])
 * Enforce a newline after import statements ([`newline-after-import`])
 * Prefer a default export if module exports a single name ([`prefer-default-export`])
+* Limit the maximum number of dependencies a module can have. ([`max-dependencies`])
 
 [`imports-first`]: ./docs/rules/imports-first.md
 [`no-duplicates`]: ./docs/rules/no-duplicates.md
@@ -69,7 +73,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`order`]: ./docs/rules/order.md
 [`newline-after-import`]: ./docs/rules/newline-after-import.md
 [`prefer-default-export`]: ./docs/rules/prefer-default-export.md
-
+[`max-dependencies`]: ./docs/rules/max-dependencies.md
 
 ## Installation
 
@@ -265,6 +269,32 @@ Contribution of more such shared configs for other platforms are welcome!
 
 An array of folders. Resolved modules only from those folders will be considered as "external". By default - `["node_modules"]`. Makes sense if you have configured your path or webpack to handle your internal paths differently and want to considered modules from some folders, for example `bower_components` or `jspm_modules`, as "external".
 
+#### `import/parsers`
+
+A map from parsers to file extension arrays. If a file extension is matched, the
+dependency parser will require and use the map key as the parser instead of the
+configured ESLint parser. This is useful if you're inter-op-ing with TypeScript
+directly using Webpack, for example:
+
+```yaml
+# .eslintrc.yml
+settings:
+  import/parsers:
+    typescript-eslint-parser: [ .ts, .tsx ]
+```
+
+In this case, [`typescript-eslint-parser`](https://github.com/eslint/typescript-eslint-parser) must be installed and require-able from
+the running `eslint` module's location (i.e., install it as a peer of ESLint).
+
+This is currently only tested with `typescript-eslint-parser` but should theoretically
+work with any moderately ESTree-compliant parser.
+
+It's difficult to say how well various plugin features will be supported, too,
+depending on how far down the rabbit hole goes. Submit an issue if you find strange
+behavior beyond here, but steel your heart against the likely outcome of closing
+with `wontfix`.
+
+
 #### `import/resolver`
 
 See [resolvers](#resolvers).

docs/rules/max-dependencies.md

@@ -0,0 +1,44 @@
+# max-dependencies
+
+Forbid modules to have too many dependencies (`import` or `require` statements).
+
+This is a useful rule because a module with too many dependencies is a code smell, and usually indicates the module is doing too much and/or should be broken up into smaller modules.
+
+Importing multiple named exports from a single module will only count once (e.g. `import {x, y, z} from './foo'` will only count as a single dependency).
+
+### Options
+
+This rule takes the following option:
+
+`max`: The maximum number of dependencies allowed. Anything over will trigger the rule. **Default is 10** if the rule is enabled and no `max` is specified.
+
+You can set the option like this:
+
+```js
+"import/max-dependencies": ["error", {"max": 10}]
+```
+
+
+## Example
+
+Given a max value of `{"max": 2}`:
+
+### Fail
+
+```js
+import a from './a'; // 1
+const b = require('./b'); // 2
+import c from './c'; // 3 - exceeds max!
+```
+
+### Pass
+
+```js
+import a from './a'; // 1
+const anotherA = require('./a'); // still 1
+import {x, y, z} from './foo'; // 2
+```
+
+## When Not To Use It
+
+If you don't care how many dependencies a module has.

docs/rules/no-absolute-path.md

@@ -0,0 +1,27 @@
+# Forbid import of modules using absolute paths
+
+Node.js allows the import of modules using an absolute path such as `/home/xyz/file.js`. That is a bad practice as it ties the code using it to your computer, and therefore makes it unusable in packages distributed on `npm` for instance.
+
+## Rule Details
+
+### Fail
+
+```js
+import f from '/foo';
+import f from '/some/path';
+
+var f = require('/foo');
+var f = require('/some/path');
+```
+
+### Pass
+
+```js
+import _ from 'lodash';
+import foo from 'foo';
+import foo from './foo';
+
+var _ = require('lodash');
+var foo = require('foo');
+var foo = require('./foo');
+```

docs/rules/no-extraneous-dependencies.md

@@ -19,6 +19,13 @@ You can set the options like this:
 "import/no-extraneous-dependencies": ["error", {"devDependencies": false, "optionalDependencies": false, "peerDependencies": false}]
 ```
 
+You can also use an array of globs instead of literal booleans:
+
+```js
+"import/no-extraneous-dependencies": ["error", {"devDependencies": ['*.test.js', '*.spec.js']}]
+```
+
+When using an array of globs, the setting will be activated if the name of the file being linted matches a single glob in the array.
 
 ## Rule Details
 

docs/rules/no-nodejs-modules.md

@@ -2,6 +2,12 @@
 
 Forbid the use of Node.js builtin modules. Can be useful for client-side web projects that do not have access to those modules.
 
+### Options
+
+This rule supports the following options:
+
+- `allow`: Array of names of allowed modules. Defaults to an empty array.
+
 ## Rule Details
 
 ### Fail
@@ -24,6 +30,9 @@ import foo from './foo';
 var _ = require('lodash');
 var foo = require('foo');
 var foo = require('./foo');
+
+/* eslint import/no-nodejs-modules: ["error", {"allow": ["path"]}] */
+import path from 'path';
 ```
 
 ## When Not To Use It

docs/rules/prefer-default-export.md

@@ -1,6 +1,6 @@
 # prefer-default-export
 
-When there is only a single export from a module prefer using default export over named export.
+When there is only a single export from a module, prefer using default export over named export.
 
 ## Rule Details
 
@@ -9,7 +9,7 @@ The following patterns are considered warnings:
 ```javascript
 // bad.js
 
-// There is only a single module export and its a named export.
+// There is only a single module export and it's a named export.
 export const foo = 'foo';
 
 ```
@@ -28,15 +28,15 @@ export default 'bar';
 ```javascript
 // good2.js
 
-// There is more thank one named exports in the module.
+// There is more than one named export in the module.
 export const foo = 'foo';
 export const bar = 'bar';
 ```
 
 ```javascript
 // good3.js
 
-// There is more thank one named exports in the module
+// There is more than one named export in the module
 const foo = 'foo';
 const bar = 'bar';
 export { foo, bar }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-import",
-  "version": "1.13.0",
+  "version": "1.14.0",
   "description": "Import with sanity.",
   "main": "lib/index.js",
   "directories": {
@@ -45,24 +45,26 @@
   "homepage": "https://github.com/benmosher/eslint-plugin-import",
   "devDependencies": {
     "babel-eslint": "next",
-    "babel-plugin-istanbul": "^1.0.3",
+    "babel-plugin-istanbul": "^2.0.1",
     "babel-preset-es2015": "^6.6.0",
     "babel-preset-es2015-loose": "^7.0.0",
     "babel-register": "6.9.0",
     "chai": "^3.4.0",
     "coveralls": "^2.11.4",
     "cross-env": "^2.0.0",
     "eslint": "2.x",
-    "eslint-plugin-import": "next",
     "eslint-import-resolver-node": "file:./resolvers/node",
     "eslint-import-resolver-webpack": "file:./resolvers/webpack",
+    "eslint-plugin-import": "next",
     "gulp": "^3.9.0",
     "gulp-babel": "6.1.2",
     "istanbul": "^0.4.0",
     "mocha": "^2.2.1",
     "nyc": "^7.0.0",
     "redux": "^3.0.4",
-    "rimraf": "2.5.2"
+    "rimraf": "2.5.2",
+    "typescript": "^1.8.10",
+    "typescript-eslint-parser": "^0.2.0"
   },
   "peerDependencies": {
     "eslint": "2.x - 3.x"
@@ -71,7 +73,7 @@
     "builtin-modules": "^1.1.1",
     "contains-path": "^0.1.0",
     "debug": "^2.2.0",
-    "doctrine": "1.2.x",
+    "doctrine": "1.3.x",
     "es6-map": "^0.1.3",
     "es6-set": "^0.1.4",
     "eslint-import-resolver-node": "^0.2.0",

resolvers/node/CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this resolver will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).
 
+## v0.2.3 - 2016-08-20
+### Added
+- debug logging (use `DEBUG=eslint-plugin-import:resolver:node eslint [...]`)
+
 ## v0.2.2 - 2016-07-14
 ### Fixed
 - Node resolver no longer declares the import plugin as a `peerDependency`. See [#437]

resolvers/node/index.js

@@ -2,13 +2,25 @@ var resolve = require('resolve')
   , path = require('path')
   , assign = require('object-assign')
 
+var log = require('debug')('eslint-plugin-import:resolver:node')
+
 exports.interfaceVersion = 2
 
 exports.resolve = function (source, file, config) {
-  if (resolve.isCore(source)) return { found: true, path: null }
+  log('Resolving:', source, 'from:', file)
+  var resolvedPath
+
+  if (resolve.isCore(source)) {
+    log('resolved to core')
+    return { found: true, path: null }
+  }
+
   try {
-    return { found: true, path: resolve.sync(source, opts(file, config)) }
+    resolvedPath = resolve.sync(source, opts(file, config))
+    log('Resolved to:', resolvedPath)
+    return { found: true, path: resolvedPath }
   } catch (err) {
+    log('resolve threw error:', err)
     return { found: false }
   }
 }