Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[import/default] typescript - esModuleInterop value not read correctly #1908

Closed
Ebooth opened this issue Sep 24, 2020 · 2 comments · Fixed by #2240
Closed

[import/default] typescript - esModuleInterop value not read correctly #1908

Ebooth opened this issue Sep 24, 2020 · 2 comments · Fixed by #2240

Comments

@Ebooth
Copy link

Ebooth commented Sep 24, 2020

The following PR was created to detect the esModuleInterop parameter in tsconfig.json. 0b585a1

It seems that the tsconfig.json file is loaded like a text file. So any extended configuration provided in the "extends" parameter of the tsconfig.json file won't be detected.

Expected:
I can set the esModuleInterop value in a tsconfig.base.json that will be extended by tsconfig.json and the rule import/default will work

Here you can find a reproduction of the bug:
https://github.com/Ebooth/eslint-plugin-import-esModuleInterop-bug

Also it could be nice to add support for monorepo as the current code works only in you have one typescript project.

@ljharb
Copy link
Member

ljharb commented Sep 24, 2020

Hmm, I would expect tsConfigLoader to resolve "extends".

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 28, 2021

We hit this a short while ago, and I've only now gotten around to submitting a fix - sorry!

See: #2240

@ljharb ljharb closed this as completed in 9a744f7 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants