import/no-cycle ignoreExternal does not work for external scoped modules

[johgoe]

A module with name @babel/core seems not to be a external module for the rule

"import/no-cycle": [2, {  ignoreExternal: true   }

Reason seems to be

eslint-plugin-import/src/core/importType.js

Line 32 in 9cc1654

return isModule(name) && isExternalPath(name, settings, path, getContextPackagePath(context));

which is checking isModule(name) && isExternalPath(name, settings, path, getContextPackagePath(context));

instead of

(isModule(name) || isScopedModule(name)) && isExternalPath(name, settings, path, getContextPackagePath(context));

[ljharb]

Can you help provide a test case?

[ljharb]

I'm also a bit confused why importType has both isScoped and isScopedModule :-) it kind of seems like isScoped is the more robust one.

[johgoe]

@ljharb I prepared a small sample project in which @apollo/client is not recognized as external module

My sample project is https://github.com/johgoe/eslint-plugin-import-2258

[johgoe]

@ljharb #2282 will fix this issue.