Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak (#1266) #1275

Merged
merged 1 commit into from
Jan 29, 2019
Merged

fix memory leak (#1266) #1275

merged 1 commit into from
Jan 29, 2019

Conversation

benmosher
Copy link
Member

Leak was caused by V8 unnecessarily retaining the SourceCode object used to parse comments for @deprecated tags. It has no reason to stick around.

Also I have been using no-deprecated for years and it has been very helpful, so I removed the "Stage 0" warning.

Will merge and release once CI passes.

@benmosher benmosher mentioned this pull request Jan 29, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.315% when pulling 7db995e on ben/1266-mem-leak into 1ec80fa on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.315% when pulling 7db995e on ben/1266-mem-leak into 1ec80fa on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.315% when pulling 7db995e on ben/1266-mem-leak into 1ec80fa on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.315% when pulling 7db995e on ben/1266-mem-leak into 1ec80fa on master.

ljharb
ljharb approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gross, but not too bad :-)

@benmosher benmosher merged commit e72a336 into master Jan 29, 2019
@benmosher benmosher deleted the ben/1266-mem-leak branch January 29, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmosher @coveralls @ljharb