Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] TypeScript named type exports #1316

Closed

Conversation

schmod
Copy link
Contributor

@schmod schmod commented Apr 8, 2019

This PR is to test a confusing Travis CI build failure that's blocking #1304.

Do not merge this PR. Once tests are passing, I'll close this PR and we'll cherry-pick any new commits into #1304.

@schmod schmod force-pushed the feature/typescript-export-type branch from 5a13d7c to 1914fd6 Compare April 8, 2019 16:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.862% when pulling 5a13d7c on schmod:feature/typescript-export-type into 3aefa79 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.862% when pulling 5a13d7c on schmod:feature/typescript-export-type into 3aefa79 on benmosher:master.

@coveralls
Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 97.862% when pulling 1914fd6 on schmod:feature/typescript-export-type into 3aefa79 on benmosher:master.

@schmod
Copy link
Contributor Author

schmod commented Apr 8, 2019

AppVeyor is failing, but it looks like master is also failing for similar reasons?

@ljharb
Copy link
Member

ljharb commented Apr 8, 2019

@schmod I’d have preferred you not open this PR; redundant PRs can’t be deleted from the git log (when PR refs are fetched). I’ll now have to keep this open and in sync with #1304 until both are merged.

Don’t worry about appveyor failing.

@schmod
Copy link
Contributor Author

schmod commented Apr 8, 2019

I only opened this to kick off a Travis build. Would it make things better if I close it now?

@ljharb
Copy link
Member

ljharb commented Apr 8, 2019

No, at this point it has to be left open.

In the future, you can enable travis on your fork, and then just pushing a branch to it will kick off a build for you :-)

@ljharb ljharb closed this Apr 12, 2019
@ljharb ljharb force-pushed the feature/typescript-export-type branch from 1914fd6 to 49af9d8 Compare April 12, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants