[New] Support for ESLint v8 #2191

ota-meshi · 2021-08-16T04:18:39Z

This PR updates this plugin to support ESLint v8.

ljharb

I'd prefer to find ways so the existing tests do not change at all, to increase confidence that we're not breaking eslint 2-7 support.

tests/dep-time-travel.sh

tests/src/cli.js

tests/src/rules/no-amd.js

ota-meshi · 2021-08-16T05:36:20Z

Hmm. I'm not sure what caused this error.

Error while loading rule 'import/no-unused-modules': Failed to load plugin 'import' declared in '.eslintrc': Package subpath './lib/util/glob-util' is not defined by "exports" in /home/runner/work/eslint-plugin-import/eslint-plugin-import/node_modules/eslint/package.json

I think I've fixed it so that this issue doesn't happen.

https://github.com/import-js/eslint-plugin-import/pull/2191/files#diff-7d2908b010ec724c0f3a0d7615cb91f4673d765d52c6ba6607501e23470f2966R21

I have removed the import plugin configuration from ./.eslintrc in my local environment and most tests work fine with npm run tests-only.
I thought that in CI it works fine with linklocal without changing ./.eslintrc, is that wrong?

ljharb · 2021-08-16T06:01:53Z

That message suggests that we're pulling lib/util/glob-util somewhere, and that's no longer a permitted path in eslint.

ota-meshi · 2021-08-16T06:18:58Z

lib/util/glob-util appears to be used in the final failover.

https://github.com/import-js/eslint-plugin-import/pull/2191/files#diff-7d2908b010ec724c0f3a0d7615cb91f4673d765d52c6ba6607501e23470f2966R51

But the line number in the error seems to point to the previous module (line number 43, new line number is 51).
Is eslint-plugin-import(2.x) in node_modules used for testing?

ljharb · 2021-08-16T06:48:18Z

I think the way things work is that the previous version ends up in node_modules, so it's possible the try/catch stuff would need to be landed and published first - but hopefully there's another alternative.

ota-meshi · 2021-08-16T06:50:19Z

FileEnumerator#iterateFiles loads the node_modules plugin from eslintrc.
I think we can test it correctly by linking myself eslint-plugin-import to a dependency eslint-plugin-import, is there a way to do this in CI?

ota-meshi · 2021-08-17T01:39:14Z

tests/dep-time-travel.sh

+  npm i --no-save eslint-plugin-import@'.' -f
+  echo "Build self"
+  npm run build
+fi


I made it link as a workaround to get the test to work which fails due to eslint-plugin-import in node_modules.

Once this is published, will this workaround no longer be needed?

I expect that the workaround will be unnecessary if we release eslint-plugin-import and change it to use it.
I think that we can also undo .nycrc change.
https://github.com/import-js/eslint-plugin-import/pull/2191/files#r690041296

tests/src/cli.js

ota-meshi · 2021-08-17T01:47:45Z

At this point, I think we've been able to confirm that at least the no-unused-modules.js changes work.
Please let me know if you have any advice on how to change the test cases and CI.

ota-meshi · 2021-08-17T01:49:55Z

package.json

@@ -71,7 +71,8 @@
    "chai": "^4.3.4",
    "coveralls": "^3.1.0",
    "cross-env": "^4.0.0",
-    "eslint": "^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0",
+    "escope": "^3.6.0",


This change is a workaround to prevent the babel-eslint patch from crashing.

https://github.com/babel/babel-eslint/blob/v8.2.6/lib/patch-eslint-scope.js#L31

tests/src/cli.js

ljharb · 2021-08-17T04:55:52Z

.nycrc

@@ -10,6 +10,7 @@
 	"exclude": [
 		"coverage",
 		"test",
-		"tests"
+		"tests",
+		"lib"


why is this needed?

This was necessary because it takes a long time to load eslint-plugin-import.

#2191 (comment)

package.json

src/rules/no-unused-modules.js

tests/dep-time-travel.sh

tests/src/cli.js

ota-meshi · 2021-08-18T05:35:19Z

I think I've done everything I can do with eslint v8 beta right now.
At this time, I understand that this PR will not be merged as is, as CI contains many workarounds.
If you want to merge only the changes in src/rules/no-unused-modules.js and tests/src/cli.js, please let me know as I will open another PR. We have confirmed that these changes work well with the CI of this PR.

ljharb · 2021-08-19T18:27:50Z

The test one, sure - but for the rule, I think it's better if it fails in eslint 8 prior to us supporting it officially.

ota-meshi · 2021-08-25T08:13:27Z

I will open a PR that changes tests/src/cli.js.

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues: - [x] wait for import-js/eslint-plugin-import#2191 to be released - [ ] wait for gajus/eslint-plugin-flowtype#496 to be released - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [ ] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [ ] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [x] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (adeira/universe#3625) adeira-source-id: b194be7e4f2fc10d51a10ed8753c440414e36b4d

[New] Support eslint v8

62e2d88

ota-meshi force-pushed the eslint-v8 branch from 67c403b to 4635716 Compare August 16, 2021 04:21

ljharb requested changes Aug 16, 2021

View reviewed changes

tests/dep-time-travel.sh Outdated Show resolved Hide resolved

tests/src/cli.js Outdated Show resolved Hide resolved

tests/src/cli.js Outdated Show resolved Hide resolved

tests/src/rules/no-amd.js Outdated Show resolved Hide resolved

ota-meshi mentioned this pull request Aug 16, 2021

Fix test cases of no-amd and no-commonjs #2193

Merged

ota-meshi commented Aug 17, 2021

View reviewed changes

tests/src/cli.js Outdated Show resolved Hide resolved

ota-meshi commented Aug 17, 2021

View reviewed changes

tests/src/cli.js Outdated Show resolved Hide resolved

ljharb reviewed Aug 17, 2021

View reviewed changes

ota-meshi mentioned this pull request Aug 17, 2021

[Tests] cli: test the current plugin, not an installed one #2197

Merged

ota-meshi mentioned this pull request Aug 25, 2021

[Tests] use ESLint class in cli test #2208

Merged

ota-meshi force-pushed the eslint-v8 branch 3 times, most recently from d9b1da2 to 4733e0a Compare August 27, 2021 03:38

ljharb mentioned this pull request Aug 29, 2021

Support ESLint 8.x #2211

Closed

1 task

danielbachhuber mentioned this pull request Oct 13, 2021

Bump eslint-plugin-import from 2.24.2 to 2.25.2 Strategy11/nutrifox-plugin#261

Merged

ykzts mentioned this pull request Oct 14, 2021

Support ESLint v8 vercel/next.js#29865

Merged

8 tasks

koba04 mentioned this pull request Oct 15, 2021

feat: support ESLInt v8 cybozu/eslint-config#501

Merged

1 task

Belco90 mentioned this pull request Oct 17, 2021

chore(dev-dependencies): upgrade ESLint and plugins to v8 testing-library/eslint-plugin-testing-library#499

Closed

66 tasks

sync-by-unito bot mentioned this pull request Nov 1, 2021

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.2 numbersprotocol/capture-lite#1026

Closed

sync-by-unito bot mentioned this pull request Dec 1, 2021

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.3 numbersprotocol/capture-lite#1066

Closed

sync-by-unito bot mentioned this pull request Feb 1, 2022

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.4 numbersprotocol/capture-lite#1230

Closed

sync-by-unito bot mentioned this pull request May 1, 2022

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.26.0 numbersprotocol/capture-lite#1581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] Support for ESLint v8 #2191

[New] Support for ESLint v8 #2191

ota-meshi commented Aug 16, 2021 •

edited by ljharb

Loading

ljharb left a comment

ota-meshi commented Aug 16, 2021

ljharb commented Aug 16, 2021

ota-meshi commented Aug 16, 2021 •

edited

Loading

ljharb commented Aug 16, 2021

ota-meshi commented Aug 16, 2021

ota-meshi Aug 17, 2021

ljharb Oct 11, 2021

ota-meshi Oct 11, 2021

ota-meshi commented Aug 17, 2021

ota-meshi Aug 17, 2021

ljharb Aug 17, 2021

ota-meshi Aug 17, 2021

ota-meshi commented Aug 18, 2021

ljharb commented Aug 19, 2021

ota-meshi commented Aug 25, 2021

[New] Support for ESLint v8 #2191

[New] Support for ESLint v8 #2191

Conversation

ota-meshi commented Aug 16, 2021 • edited by ljharb Loading

ljharb left a comment

Choose a reason for hiding this comment

ota-meshi commented Aug 16, 2021

ljharb commented Aug 16, 2021

ota-meshi commented Aug 16, 2021 • edited Loading

ljharb commented Aug 16, 2021

ota-meshi commented Aug 16, 2021

ota-meshi Aug 17, 2021

Choose a reason for hiding this comment

ljharb Oct 11, 2021

Choose a reason for hiding this comment

ota-meshi Oct 11, 2021

Choose a reason for hiding this comment

ota-meshi commented Aug 17, 2021

ota-meshi Aug 17, 2021

Choose a reason for hiding this comment

ljharb Aug 17, 2021

Choose a reason for hiding this comment

ota-meshi Aug 17, 2021

Choose a reason for hiding this comment

ota-meshi commented Aug 18, 2021

ljharb commented Aug 19, 2021

ota-meshi commented Aug 25, 2021

ota-meshi commented Aug 16, 2021 •

edited by ljharb

Loading

ota-meshi commented Aug 16, 2021 •

edited

Loading