[Fix] order: Fix import ordering in TypeScript module declarations
#2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, `import/order` checks if all imports in a file are sorted. The autofix would then move all imports to the type of the file, breaking TypeScript module declarations. Closes import-js#2217
Codecov Report
@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
+ Coverage 84.04% 84.29% +0.24%
==========================================
Files 96 93 -3
Lines 3034 2979 -55
Branches 900 882 -18
==========================================
- Hits 2550 2511 -39
+ Misses 484 468 -16
Continue to review full report at Codecov.
|
ljharb
force-pushed
the
fix-order-typescript-module-declarations
branch
from
7f25ace
to
47ea669
Compare
ljharb
changed the title
order: Fix import ordering in TypeScript module declarationsorder: Fix import ordering in TypeScript module declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
import/orderchecks if all imports in a file are sorted. The autofix would then move all imports to the type of the file, breaking TypeScript module declarations.Closes #2217