[Tests] fix skip usage

[jablko]

Conditionally skipping tests doesn't work this way, I think?

[ljharb]

Thanks, this seems great

[codecov]

Codecov Report

Merging #2232 (430d16c) into main (fd85369) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2232   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          65       65           
  Lines        2687     2687           
  Branches      889      889           
=======================================
  Hits         2559     2559           
  Misses        128      128           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd85369...430d16c. Read the comment docs.

[ljharb]

I just rebased to tweak the commit messages; two tests are failing.

[jablko]

I just rebased to tweak the commit messages;

Got them, thanks!

two tests are failing.

Hopefully this does the trick: We downgrade eslint-import-resolver-typescript on Node.js < 8:

eslint-plugin-import/tests/dep-time-travel.sh

Lines 32 to 35 in fd85369

	# typescript-eslint-parser 1.1.1+ is not compatible with node 6
	if [[ "$TRAVIS_NODE_VERSION" -lt "8" ]]; then
	echo "Downgrading eslint-import-resolver-typescript..."
	npm i --no-save eslint-import-resolver-typescript@1.0.2

1.0.2 doesn't resolve .js extensions (I presume) and this test needs a resolved import:

eslint-plugin-import/src/rules/no-extraneous-dependencies.js

Line 176 in fd85369

if (!resolved) { return; }