[New] no-extraneous-dependencies: added includeInternal option to validate imports of internal dependencies

[bdwain]

…alidate imports of internal dependencies

Fixes #1678

[ljharb]

Solid, thanks!

[ljharb]

Looks like a ton of tests are failing.

[bdwain]

it looks like you pushed a change? I had

  if (typeOfImport !== 'external' && (typeOfImport !== 'internal' || !depsOptions.verifyInternalDeps)) {
    return;
  }

but now it's

  if (
    typeOfImport !== 'external'
    && (depsOptions.verifyInternalDeps && typeOfImport !== 'internal')
  ) {

but that looks wrong. it should be

  if (
    typeOfImport !== 'external'
    && (!depsOptions.verifyInternalDeps || typeOfImport !== 'internal')
  ) {

[ljharb]

oh duh, yes, that's my bad. fixing :-)

[codecov]

Codecov Report

Base: 95.15% // Head: 95.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (74f39d9) compared to base (7f251b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files          66       66           
  Lines        2828     2831    +3     
  Branches      949      951    +2     
=======================================
+ Hits         2691     2694    +3     
  Misses        137      137           

Impacted Files	Coverage Δ
src/rules/no-extraneous-dependencies.js	98.21% <100.00%> (+0.04%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bdwain]

thanks!

[bdwain]

@ljharb any plans to do a release soon? Would love to start using this change.