[Fix] no-unused-modules: don't error out when running with flat config and an eslintrc isn't present

[michaelfaith]

This change adjusts what we're doing if an error is thrown while attempting to enumerate lintable files in the no-used-modules rule, when users are running with flat config. Now, if FileEnumerator throws due to a lack of eslintrc and the user is running with flat config, we catch the error and rethrow with a more informative message.

I also cleaned up the original aspects of the implementation that was using the proposed eslint context functions, since that proposal was walked back and the API was never introduced.

Note: This isn't an ideal state, since this rule still relies on the legacy api to understand what needs to be ignored. Remaining tethered to the legacy config system is going to need to be solved at some point.

Fixes #3079

[ljharb]

Looks pretty good, thanks!

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (8b2d570) to head (9993d21).

Files with missing lines	Patch %	Lines
src/rules/no-unused-modules.js	25.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3116      +/-   ##
==========================================
- Coverage   95.04%   92.06%   -2.98%     
==========================================
  Files          84       83       -1     
  Lines        3634     3618      -16     
  Branches     1279     1276       -3     
==========================================
- Hits         3454     3331     -123     
- Misses        180      287     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michaelfaith]

Addressed lint errors

[michaelfaith]

Updated, based on feedback in #3079 to not attempt to avoid the error, but to instead rethrow with a more informative message. I updated the PR description to reflect the new approach. There's not a great way to test this now. With the integration tests before, we could remove the rc config, run lint, and observe that it didn't error out. Now we're wanting it to error out when no rc is present, and there's not a great way to recreate that in the rule's unit tests or in integration tests that don't throw (unless we write a custom node script to serve as an integration test). Thoughts?

[ljharb]

I suppose we could have a test make a temp dir (using tmp), copy an example into it, run npm install in it, and then invoke eslint inside it?

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@angular-eslint/template-parser@13.5.0	Transitive: environment, filesystem, unsafe	+12	5.06 MB	jameshenry
npm/@types/eslint@8.56.12	None	0	193 kB	types
npm/@typescript-eslint/parser@5.62.0	Transitive: environment, filesystem, unsafe	+13	2.34 MB	jameshenry
npm/babel-cli@6.26.0	Transitive: environment, filesystem	+4	579 kB	hzoo
npm/babel-eslint@10.1.0	Transitive: environment	+9	4.03 MB	kaicataldo
npm/babel-plugin-module-resolver@2.7.1	filesystem	0	29.7 kB	tleunen
npm/babel-preset-airbnb@2.6.0	Transitive: environment, filesystem	+56	524 kB	lencioni
npm/babel-preset-flow@6.23.0	None	+2	6.54 kB	loganfsmyth
npm/chai@4.5.0	None	+2	783 kB	chaijs
npm/cross-env@4.0.0	environment Transitive: filesystem, shell	+1	35.5 kB	kentcdodds

View full report↗︎

[michaelfaith]

I suppose we could have a test make a temp dir (using tmp), copy an example into it, run npm install in it, and then invoke eslint inside it?

Added a test that does the following:

• creates a tmp folder
• copies the v9 example folder into it
• runs exec to install the plugin from cwd and run the lint command
• catches the error and validates that the message includes our new verbiage